drivers: sensor: lis2dh: Configurable latch and mode for any movement #50004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
galak,
gmarull,
mbolivar-nordic and
teburd
MaureenHelm
requested changes
Sep 7, 2022
pdgendt
force-pushed
the
drivers-sensor-lis2dh-anym
branch
from
51cb602 to
edbad12
Compare
mbolivar-nordic
suggested changes
Sep 13, 2022
pdgendt
force-pushed
the
drivers-sensor-lis2dh-anym
branch
from
edbad12 to
c9119d3
Compare
pdgendt
force-pushed
the
drivers-sensor-lis2dh-anym
branch
from
c9119d3 to
df043ea
Compare
mbolivar-nordic
suggested changes
Sep 14, 2022
Contributor
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
Sorry I was unclear, but this is still not done:
Can you please move the YAML comments explaining the values to the description field, so they show up in the bindings index?
Add 2 properties to configure the "any movement" event. * Ability to disable the interrupt latch * Select movement mode Signed-off-by: Pieter De Gendt <[email protected]>
Remove 'required: false' for boolean properties. Signed-off-by: Pieter De Gendt <[email protected]>
Remove 'required: false' for boolean properties. Signed-off-by: Pieter De Gendt <[email protected]>
Remove 'required: false' for boolean properties. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
drivers-sensor-lis2dh-anym
branch
from
df043ea to
9f716d3
Compare
mbolivar-nordic
approved these changes
Sep 16, 2022
MaureenHelm
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 properties to configure the "any movement" event.